Issue 227703012: Mojo: MessageInTransit clean-up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227703012: Mojo: MessageInTransit clean-up. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: MessageInTransit clean-up. * Eliminate empty namespace. * Improve comments. * Remove some redundant checks (well, make them DCHECKs). * Increase paranoia slightly (in checking the validity of the secondary buffer). R=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262326

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -30 lines)			Patch
	M	mojo/system/message_in_transit.h	View		1 chunk	+1 line, -2 lines	1 comment	Download
	M	mojo/system/message_in_transit.cc	View		7 chunks	+28 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Nice. LGTM. https://codereview.chromium.org/227703012/diff/1/mojo/system/message_in_transit.h File mojo/system/message_in_transit.h (right): https://codereview.chromium.org/227703012/diff/1/mojo/system/message_in_transit.h#newcode265 mojo/system/message_in_transit.h:265: // The maximum possible size of a ...

6 years, 8 months ago (2014-04-08 00:18:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/227703012/1

6 years, 8 months ago (2014-04-08 00:52:18 UTC) #4

Message was sent while issue was closed.

Change committed as 262326

Expand Messages | Collapse Messages