Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 227703011: Revert of Revert r245379 Add missing test targets to chrome_official_builder for Windows (Closed)

Created:
6 years, 8 months ago by jschuh
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Revert r245379 Add missing test targets to chrome_official_builder for Windows (https://codereview.chromium.org/227673007/) Reason for revert: The release team owns these tests now. Original issue's description: > Revert r245379 Add missing test targets to chrome_official_builder for Windows > > These were removed because they break parts of the official build > > BUG=334006 > R=scottmg,phajdan.jr@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262252 TBR=phajdan.jr@chromium.org,scottmg@chromium.org,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=334006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M build/all.gyp View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jschuh
Created Revert of Revert r245379 Add missing test targets to chrome_official_builder for Windows
6 years, 8 months ago (2014-04-08 00:06:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/227703011/1
6 years, 8 months ago (2014-04-08 00:07:34 UTC) #2
commit-bot: I haz the power
Change committed as 262263
6 years, 8 months ago (2014-04-08 00:09:31 UTC) #3
Paweł Hajdan Jr.
6 years, 8 months ago (2014-04-17 13:47:38 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698