Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2277003003: Attempt to load sdk.ds from the only embedder. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Attempt to load sdk.ds from the only embedder. And return it only in strong mode. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ce5a17ab63561d008ff75a4d590e478bdff0f9e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -46 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 3 chunks +22 lines, -4 lines 0 comments Download
M pkg/analyzer/test/embedder_tests.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 9 chunks +25 lines, -25 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 5 chunks +43 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-25 01:05:47 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-08-25 13:14:43 UTC) #2
scheglov
4 years, 3 months ago (2016-08-25 16:08:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce5a17ab63561d008ff75a4d590e478bdff0f9e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698