Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2277003002: [OfflinePages] Removes IsOfflinePagesEnabled() computed flag check from GetOfflinePageForOfflineURL (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OfflinePages] Removes IsOfflinePagesEnabled() computed flag check from GetOfflinePageForOfflineURL so that TabAndroid::GetBookmarkId will work with only Downloads UI feature flag and no other offline pages feature flags enabled. BUG=639802 Committed: https://crrev.com/2d310be53a1a42a4f7a60e9ce829a9f55fa9dbae Cr-Commit-Position: refs/heads/master@{#414138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/android/offline_pages/offline_page_utils.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dougarnett
4 years, 3 months ago (2016-08-24 18:07:31 UTC) #4
dougarnett
On 2016/08/24 18:07:31, dougarnett wrote: Btw, this affects these 3 apis: OfflinePageUtils::MarkPageAccessed OfflinePageUtils::IsOfflinePage OfflinePageUtils::MaybeGetOnlineURLForOfflineURL
4 years, 3 months ago (2016-08-24 18:15:38 UTC) #5
fgorski
lgtm
4 years, 3 months ago (2016-08-24 18:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277003002/1
4 years, 3 months ago (2016-08-24 20:17:50 UTC) #10
Dmitry Titov
lgtm, thanks!
4 years, 3 months ago (2016-08-24 20:19:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-24 20:49:26 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 20:51:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d310be53a1a42a4f7a60e9ce829a9f55fa9dbae
Cr-Commit-Position: refs/heads/master@{#414138}

Powered by Google App Engine
This is Rietveld 408576698