Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2276983002: Prepend "Get" to method name if method name conflicts with return type name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-partition-allocator-new-array-delete-array
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index 12165b7ad788fcb05f1e2009d5e57fd1f7ee344c..d45e27b52f00f7638a9b42b9cd4781887436faa5 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -176,6 +176,23 @@ struct StructInBlink {
bool function() { return true; }
};
+class BitVector {
+ public:
+ class OutOfLineBits {};
+ enum Foo { Blah };
+ struct Bar {};
+
+ // Naive renaming will break the build, by leaving return type the same
+ // as method the name - to avoid this "Get" prefix needs to be prepended
+ // as suggested in https://crbug.com/582312#c17.
+ const OutOfLineBits* outOfLineBits() const { return nullptr; }
+ Foo foo() { return Blah; }
+ const Bar& bar() const { return m_bar; }
+
+ private:
+ Bar m_bar;
+};
+
} // namespace blink
namespace WTF {

Powered by Google App Engine
This is Rietveld 408576698