Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc

Issue 2276983002: Prepend "Get" to method name if method name conflicts with return type name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-partition-allocator-new-array-delete-array
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
index 766145e4f422e2db9025a97b130530bfd4de7d06..dd4fd23501ebc0c7aa5f4ff478fbf17e5513324e 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
@@ -172,6 +172,23 @@ struct StructInBlink {
bool Function() { return true; }
};
+class BitVector {
+ public:
+ class OutOfLineBits {};
+ enum Foo { kBlah };
+ struct Bar {};
+
+ // Naive renaming will break the build, by leaving return type the same
+ // as method the name - to avoid this "Get" prefix needs to be prepended
+ // as suggested in https://crbug.com/582312#c17.
+ const OutOfLineBits* GetOutOfLineBits() const { return nullptr; }
+ Foo GetFoo() { return kBlah; }
+ const Bar& GetBar() const { return bar_; }
+
+ private:
+ Bar bar_;
+};
+
} // namespace blink
namespace WTF {

Powered by Google App Engine
This is Rietveld 408576698