Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Issue 2276953004: [compiler] Properly canonicalize handles even with concurrent recompilation. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Properly canonicalize handles even with concurrent recompilation. For concurrent recompilation we created the CompilationHandleScope after the CanonicalHandleScope, which basically disabled the canonicalization because the deferred handle creation doesn't pay attention to the canonicalization mode then. This meant that we did not canonicalize handles properly as soon as concurrent recompilation was enabled. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/052ba98d14fae5d6d0595f0272fa922df3025e10 Cr-Commit-Position: refs/heads/master@{#38882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/compiler.cc View 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-25 05:13:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the concurrent recompilation fix. Helps quite a bit with the benchmarks. Please ...
4 years, 4 months ago (2016-08-25 05:19:02 UTC) #7
Jarin
lgtm
4 years, 4 months ago (2016-08-25 05:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276953004/1
4 years, 4 months ago (2016-08-25 05:37:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 05:43:04 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 05:43:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052ba98d14fae5d6d0595f0272fa922df3025e10
Cr-Commit-Position: refs/heads/master@{#38882}

Powered by Google App Engine
This is Rietveld 408576698