Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: components/sync/driver/data_type_controller.h

Issue 2276943006: [USS] Move GetAllNodes from backend to controller (Closed)
Patch Set: clean code Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/data_type_controller.h
diff --git a/components/sync/driver/data_type_controller.h b/components/sync/driver/data_type_controller.h
index 7035b5dcb78b8dc994a0c4529f7368b64a008558..c331f638ea526dae45af4f5ca03bf50975b7b663 100644
--- a/components/sync/driver/data_type_controller.h
+++ b/components/sync/driver/data_type_controller.h
@@ -75,6 +75,9 @@ class DataTypeController
typedef base::Callback<void(syncer::ModelType, syncer::SyncError)>
ModelLoadCallback;
+ typedef base::Callback<void(const syncer::ModelType,
maxbogue 2016/08/29 21:21:17 nit: newline above? Or remove the one below StartC
Gang Wu 2016/08/30 20:56:01 Done.
+ std::unique_ptr<base::ListValue>)>
+ AllNodesCallback;
typedef std::map<syncer::ModelType, scoped_refptr<DataTypeController>>
TypeMap;
@@ -153,6 +156,8 @@ class DataTypeController
// Returns true by default.
virtual bool ReadyForStart() const;
+ virtual void GetAllNodes(const AllNodesCallback& callback) = 0;
maxbogue 2016/08/29 21:21:17 Comment please (especially that it's for debug pur
Gang Wu 2016/08/30 20:56:01 Done.
+
protected:
friend class base::RefCountedDeleteOnMessageLoop<DataTypeController>;
friend class base::DeleteHelper<DataTypeController>;

Powered by Google App Engine
This is Rietveld 408576698