[USS] Move GetAllNodes from backend to controller

components/sync/driver/proxy_data_type_controller.cc

Index: components/sync/driver/proxy_data_type_controller.cc
diff --git a/components/sync/driver/proxy_data_type_controller.cc b/components/sync/driver/proxy_data_type_controller.cc
index 99c74b78c856366553531f3c283eedf70a852041..6bbf4044234b341f1744f1405c05a6a0e21e8c04 100644
--- a/components/sync/driver/proxy_data_type_controller.cc
+++ b/components/sync/driver/proxy_data_type_controller.cc
@@ -4,6 +4,9 @@
 
 #include "components/sync/driver/proxy_data_type_controller.h"
 
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/values.h"
 #include "components/sync/api/sync_merge_result.h"
 
 namespace sync_driver {
@@ -70,4 +73,15 @@ void ProxyDataTypeController::ActivateDataType(
 void ProxyDataTypeController::DeactivateDataType(
     BackendDataTypeConfigurer* configurer) {}
 
+void ProxyDataTypeController::GetAllNodes(

[maxbogue, 2016/08/25 23:38:59]

I suspect this shouldn't need an implementation, should it? I'm a bit confused.

[Gang Wu, 2016/08/26 16:48:04]

proxy_tab is registered and enabled type, and cannot filtered out in PSS, so we
need to implement here.

+    scoped_refptr<base::SequencedTaskRunner> task_runner,
+    const AllNodesCallback& callback) {
+  ScopedVector<base::ListValue> node_lists;
+  std::vector<syncer::ModelType> types_vector;
+  types_vector.push_back(type());

[skym, 2016/08/26 18:41:39]

I know Max suggested to switch to returning a single type at a time, but just
fyi

1) Use initializer lists to make 1 element vectors. Waaay more compact than
declaring the vector, adding a single element, and then passing it along. And
we're allowed to use them now, wooo!

2) Don't use ScopedVector, std::vector<T> supports movable types now

https://bugs.chromium.org/p/chromium/issues/detail?id=554289

https://cs.chromium.org/chromium/src/base/memory/scoped_vector.h?q=ScopedVect...

[Gang Wu, 2016/08/29 20:07:41]

Done.

+  node_lists.push_back(new base::ListValue());
+  task_runner->PostTask(
+      FROM_HERE, base::Bind(callback, types_vector, base::Passed(&node_lists)));
+}
+
 }  // namespace sync_driver