Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2276943005: gn: Mention loadable_module targets in the cookbook. (Closed)

Created:
4 years, 3 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Mention loadable_module targets in the cookbook. loadable_modules are quite commonly used in tests and for plugins, yet it is barely mentioned in GN's docs. Add it to the cookbook so people porting their projects away from gyp know that the construct also exists in GN. R=brettw@chromium.org,dpranke@chromium.org Committed: https://crrev.com/11772ab50084dc52be85d02064148fbf57e0ae15 Cr-Commit-Position: refs/heads/master@{#414458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Raphael Kubo da Costa (rakuco)
4 years, 3 months ago (2016-08-25 12:54:35 UTC) #1
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-25 15:56:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276943005/1
4 years, 3 months ago (2016-08-25 15:57:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 16:48:57 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:51:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11772ab50084dc52be85d02064148fbf57e0ae15
Cr-Commit-Position: refs/heads/master@{#414458}

Powered by Google App Engine
This is Rietveld 408576698