Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 2276933003: Add data usage tracking for safe browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ping_manager.cc
diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc
index f4afeb651784fb5cc08f0dac0ef7073c2194e516..f0fed8f3444e750987f77e5ab17c6d32261cc83a 100644
--- a/chrome/browser/safe_browsing/ping_manager.cc
+++ b/chrome/browser/safe_browsing/ping_manager.cc
@@ -13,6 +13,7 @@
#include "base/strings/stringprintf.h"
#include "chrome/browser/safe_browsing/permission_reporter.h"
#include "components/certificate_reporting/error_reporter.h"
+#include "components/data_use_measurement/core/data_use_user_data.h"
#include "content/public/browser/browser_thread.h"
#include "google_apis/google_api_keys.h"
#include "net/base/escape.h"
@@ -100,6 +101,8 @@ void SafeBrowsingPingManager::ReportSafeBrowsingHit(
: net::URLFetcher::POST,
this)
.release();
+ data_use_measurement::DataUseUserData::AttachToFetcher(
+ report, data_use_measurement::DataUseUserData::SAFE_BROWSING);
report->SetLoadFlags(net::LOAD_DISABLE_CACHE);
report->SetRequestContext(request_context_getter_.get());
if (!hit_report.post_data.empty())
@@ -114,6 +117,8 @@ void SafeBrowsingPingManager::ReportThreatDetails(const std::string& report) {
net::URLFetcher* fetcher =
net::URLFetcher::Create(report_url, net::URLFetcher::POST, this)
.release();
+ data_use_measurement::DataUseUserData::AttachToFetcher(
+ fetcher, data_use_measurement::DataUseUserData::SAFE_BROWSING);
Jialiu Lin 2016/08/24 19:10:45 In addition to these two pings, download pings are
Raj 2016/08/24 20:00:01 Thanks. Added to that file as well.
fetcher->SetLoadFlags(net::LOAD_DISABLE_CACHE);
fetcher->SetRequestContext(request_context_getter_.get());
fetcher->SetUploadData("application/octet-stream", report);
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/protocol_manager.cc » ('j') | chrome/browser/safe_browsing/protocol_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698