Add data usage tracking for safe browsing

Add data usage tracking for safe browsing

BUG=527304
Committed: https://crrev.com/701cb870fa0956b4c1a774c8fb4cfcb24bd52691
Cr-Commit-Position: refs/heads/master@{#421116}

[Raj, 2016-08-24 18:52:53]

rajendrant@chromium.org changed reviewers:
+ jialiul@chromium.org, sclittle@chromium.org

[Raj, 2016-08-24 18:52:54]

jialiul@chromium.org: Please review changes in 
chrome/browser/safe_browsing/*

[Jialiu Lin, 2016-08-24 19:10:45]

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ping_manager.cc:121: fetcher,
data_use_measurement::DataUseUserData::SAFE_BROWSING);
In addition to these two pings, download pings are handled in
chrome/browser/safe_browsing/download_protection_service.cc, more specifically,

DownloadProtectionService::CheckClientDownloadRequest::SendRequest() and 
DownloadProtectionService::PPAPIDownloadRequest::SendRequest()

You might want to take a look.

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager.cc (right):

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:224:
data_use_measurement::DataUseUserData::AttachToFetcher(
We are going to deprecate this protocol manager soon. New protocol manager (pv4)
will be in components/safe_browsing_db/* code path.

[sclittle, 2016-08-24 19:28:45]

components/data_use_measurement/* lgtm

[Raj, 2016-08-24 20:00:01]

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ping_manager.cc:121: fetcher,
data_use_measurement::DataUseUserData::SAFE_BROWSING);
On 2016/08/24 19:10:45, Jialiu Lin wrote:
> In addition to these two pings, download pings are handled in
> chrome/browser/safe_browsing/download_protection_service.cc, more
specifically,
> 
> DownloadProtectionService::CheckClientDownloadRequest::SendRequest() and 
> DownloadProtectionService::PPAPIDownloadRequest::SendRequest()
> 
> You might want to take a look.

Thanks. Added to that file as well.

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager.cc (right):

https://codereview.chromium.org/2276933003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:224:
data_use_measurement::DataUseUserData::AttachToFetcher(
On 2016/08/24 19:10:45, Jialiu Lin wrote:
> We are going to deprecate this protocol manager soon. New protocol manager
(pv4)
> will be in components/safe_browsing_db/* code path. 
> 

Thanks for the heads up.
Added to that code as well.

[vakh (use Gerrit instead), 2016-08-24 20:04:52]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2016-08-24 20:04:52]

lgtm

lgtm for components/safe_browsing_db/

[Jialiu Lin, 2016-08-24 20:35:31]

lgtm

[Nathan Parker, 2016-08-24 20:37:18]

nparker@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2016-08-24 20:37:19]

lgtm

This looks interesting... How does one view accumulated bandwidth based on this
tool?

https://codereview.chromium.org/2276933003/diff/20001/components/data_use_mea...
File components/data_use_measurement/core/data_use_user_data.h (right):

https://codereview.chromium.org/2276933003/diff/20001/components/data_use_mea...
components/data_use_measurement/core/data_use_user_data.h:43: SAFE_BROWSING,
I would suggest assigning integers to these, so you can verify they match up
with histograms.xml.

[Raj, 2016-08-24 20:45:31]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-08-24 20:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276933003/#ps20001
(title: "Addressed Jialiu comments")

[commit-bot: I haz the power, 2016-08-24 20:46:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:51:17]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raj, 2016-08-24 21:19:11]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 21:20:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:25:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raj, 2016-08-24 22:13:26]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:14:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:21:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raj, 2016-09-22 19:16:41]

rajendrant@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Raj, 2016-09-22 19:16:42]

rkaplow: ptal hisograms.xml

[rkaplow, 2016-09-22 20:10:54]

lgtm

[Raj, 2016-09-22 20:32:28]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-22 20:32:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, vakh@chromium.org, jialiul@chromium.org,
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276933003/#ps60001
(title: "Added safe browsing to histograms.xml")

[commit-bot: I haz the power, 2016-09-22 20:33:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:37:56]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raj, 2016-09-26 18:30:22]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 18:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:42:26]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raj, 2016-09-27 00:08:53]

Patchset #5 (id:80001) has been deleted

[Raj, 2016-09-27 00:09:23]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 00:10:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:19:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 00:19:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raj, 2016-09-27 01:10:12]

Patchset #5 (id:100001) has been deleted

[Raj, 2016-09-27 01:11:12]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 01:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:22:48]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raj, 2016-09-27 01:36:14]

Patchset #5 (id:120001) has been deleted

[Raj, 2016-09-27 01:36:54]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 01:37:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 03:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 03:32:21]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Raj, 2016-09-27 04:24:30]

Patchset #5 (id:140001) has been deleted

[Raj, 2016-09-27 04:25:14]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 04:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raj, 2016-09-27 05:20:02]

The CQ bit was unchecked by rajendrant@chromium.org

[Raj, 2016-09-27 05:20:16]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-27 05:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, vakh@chromium.org, rkaplow@chromium.org,
jialiul@chromium.org, sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276933003/#ps160001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-27 05:20:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:30:53]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-09-27 05:33:04]

Description was changed from

==========
Add data usage tracking for safe browsing

BUG=527304
==========

to

==========
Add data usage tracking for safe browsing

BUG=527304

Committed: https://crrev.com/701cb870fa0956b4c1a774c8fb4cfcb24bd52691
Cr-Commit-Position: refs/heads/master@{#421116}
==========

[commit-bot: I haz the power, 2016-09-27 05:33:05]

Patchset 5 (id:??) landed as
https://crrev.com/701cb870fa0956b4c1a774c8fb4cfcb24bd52691
Cr-Commit-Position: refs/heads/master@{#421116}