New IPC message parameters for IDB/Blob support.

content/child/indexed_db/indexed_db_dispatcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/indexed_db/indexed_db_dispatcher.h"
 
 #include <utility>
 
 #include "base/format_macros.h"
 #include "base/lazy_instance.h"
@@ skipping 483 matching lines @@
     int32 ipc_callbacks_id,
     const std::vector<base::string16>& value) {
   DCHECK_EQ(ipc_thread_id, CurrentWorkerId());
   WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(ipc_callbacks_id);
   if (!callbacks)
     return;
   callbacks->onSuccess(WebVector<WebString>(value));
   pending_callbacks_.Remove(ipc_callbacks_id);
 }
 
-void IndexedDBDispatcher::OnSuccessValue(int32 ipc_thread_id,
-                                         int32 ipc_callbacks_id,
-                                         const std::string& value) {
-  DCHECK_EQ(ipc_thread_id, CurrentWorkerId());
-  WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(ipc_callbacks_id);
+void IndexedDBDispatcher::OnSuccessValue(
+    const IndexedDBMsg_CallbacksSuccessValue_Params& p) {
+  DCHECK_EQ(p.ipc_thread_id, CurrentWorkerId());
+  WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(p.ipc_callbacks_id);
   if (!callbacks)
     return;
   WebData web_value;
-  if (value.size())
-    web_value.assign(&*value.begin(), value.size());
+  if (p.value.size())

[cmumford, 2014/04/08 21:47:26]

Nit: was here before, but size() is O(n), but empty() is O(1)

[ericu, 2014/04/08 22:07:11]

As discussed in person, size() is likely O(1), but empty() better anyway.

+    web_value.assign(&*p.value.begin(), p.value.size());
   callbacks->onSuccess(web_value);
-  pending_callbacks_.Remove(ipc_callbacks_id);
-  cursor_transaction_ids_.erase(ipc_callbacks_id);
+  pending_callbacks_.Remove(p.ipc_callbacks_id);
+  cursor_transaction_ids_.erase(p.ipc_callbacks_id);
 }
 
 void IndexedDBDispatcher::OnSuccessValueWithKey(
-    int32 ipc_thread_id,
-    int32 ipc_callbacks_id,
-    const std::string& value,
-    const IndexedDBKey& primary_key,
-    const IndexedDBKeyPath& key_path) {
-  DCHECK_EQ(ipc_thread_id, CurrentWorkerId());
-  WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(ipc_callbacks_id);
+    const IndexedDBMsg_CallbacksSuccessValueWithKey_Params& p) {
+  DCHECK_EQ(p.ipc_thread_id, CurrentWorkerId());
+  WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(p.ipc_callbacks_id);
   if (!callbacks)
     return;
   WebData web_value;
-  if (value.size())
-    web_value.assign(&*value.begin(), value.size());
+  if (p.value.size())
+    web_value.assign(&*p.value.begin(), p.value.size());
   callbacks->onSuccess(web_value,
-                       WebIDBKeyBuilder::Build(primary_key),
-                       WebIDBKeyPathBuilder::Build(key_path));
-  pending_callbacks_.Remove(ipc_callbacks_id);
+                       WebIDBKeyBuilder::Build(p.primary_key),
+                       WebIDBKeyPathBuilder::Build(p.key_path));
+  pending_callbacks_.Remove(p.ipc_callbacks_id);
 }
 
 void IndexedDBDispatcher::OnSuccessInteger(int32 ipc_thread_id,
                                            int32 ipc_callbacks_id,
                                            int64 value) {
   DCHECK_EQ(ipc_thread_id, CurrentWorkerId());
   WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(ipc_callbacks_id);
   if (!callbacks)
     return;
   callbacks->onSuccess(value);
@@ skipping 187 matching lines @@
   typedef std::map<int32, WebIDBCursorImpl*>::iterator Iterator;
   for (Iterator i = cursors_.begin(); i != cursors_.end(); ++i) {
     if (i->first == ipc_exception_cursor_id ||
         i->second->transaction_id() != transaction_id)
       continue;
     i->second->ResetPrefetchCache();
   }
 }
 
 }  // namespace content