Issue 227693007: Fix the Mac toolchain definition in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227693007: Fix the Mac toolchain definition in the GN build. (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the Mac toolchain definition in the GN build. I did not update this when I updated the template syntax. This also fixes a typo in the GCC toolchain definition (it was just in some helpful assertions and didn't affect anything). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262491

Patch Set 1 #

Patch Set 2 : line wrapping #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	build/toolchain/gcc_toolchain.gni	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	build/toolchain/mac/BUILD.gn	View	1	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/227693007/20001

6 years, 8 months ago (2014-04-08 16:43:23 UTC) #4

Message was sent while issue was closed.

Change committed as 262491

Expand Messages | Collapse Messages