Factory methods for heap-allocated SkTypeface objects.

Factory methods for heap-allocated SkTypeface objects.

This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.

This patch makes the constructors of SkTypeface and its subclasses non-public
and instead provides factory methods for creating these objects on the heap.

BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=14080

[Dominik Grewe, 2014-04-07 16:05:09]

PTAL, thanks.

[scroggo, 2014-04-07 16:46:12]

lgtm, but cc'ing Ben, who works on our fonts.

https://codereview.chromium.org/227693003/diff/1/src/core/SkTypeface.cpp
File src/core/SkTypeface.cpp (left):

https://codereview.chromium.org/227693003/diff/1/src/core/SkTypeface.cpp#oldc...
src/core/SkTypeface.cpp:88: gDefaultTypefaces[style] = SkNEW(SkEmptyTypeface);
I'm surprised this doesn't already use a singleton, but perhaps there's a
reason?

[bungeman-skia, 2014-04-07 17:35:20]

I'll second scroggos's comment, in that we do need to fix that at some point.
But I don't see why it should block this right now. lgtm

[Dominik Grewe, 2014-04-07 17:40:31]

On 2014/04/07 17:35:20, bungeman1 wrote:
> I'll second scroggos's comment, in that we do need to fix that at some point.
> But I don't see why it should block this right now. lgtm

Thanks. I've added a comment.

[Dominik Grewe, 2014-04-07 18:17:01]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-04-07 18:17:11]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/227693003/20001

[commit-bot: I haz the power, 2014-04-07 19:34:27]

Change committed as 14080