Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 } 239 }
240 240
241 // Possibly set up a local binding to the new target value. 241 // Possibly set up a local binding to the new target value.
242 Variable* new_target_var = info->scope()->new_target_var(); 242 Variable* new_target_var = info->scope()->new_target_var();
243 if (new_target_var != nullptr) { 243 if (new_target_var != nullptr) {
244 Comment cmnt(masm_, "[ new.target"); 244 Comment cmnt(masm_, "[ new.target");
245 SetVar(new_target_var, edx, ebx, ecx); 245 SetVar(new_target_var, edx, ebx, ecx);
246 } 246 }
247 247
248 // Possibly allocate RestParameters 248 // Possibly allocate RestParameters
249 int rest_index; 249 Variable* rest_param = info->scope()->rest_parameter();
250 Variable* rest_param = info->scope()->rest_parameter(&rest_index); 250 if (rest_param != nullptr) {
251 if (rest_param) {
252 Comment cmnt(masm_, "[ Allocate rest parameter array"); 251 Comment cmnt(masm_, "[ Allocate rest parameter array");
253 if (!function_in_register) { 252 if (!function_in_register) {
254 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 253 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
255 } 254 }
256 FastNewRestParameterStub stub(isolate()); 255 FastNewRestParameterStub stub(isolate());
257 __ CallStub(&stub); 256 __ CallStub(&stub);
258 function_in_register = false; 257 function_in_register = false;
259 SetVar(rest_param, eax, ebx, edx); 258 SetVar(rest_param, eax, ebx, edx);
260 } 259 }
261 260
(...skipping 3376 matching lines...) Expand 10 before | Expand all | Expand 10 after
3638 isolate->builtins()->OnStackReplacement()->entry(), 3637 isolate->builtins()->OnStackReplacement()->entry(),
3639 Assembler::target_address_at(call_target_address, unoptimized_code)); 3638 Assembler::target_address_at(call_target_address, unoptimized_code));
3640 return ON_STACK_REPLACEMENT; 3639 return ON_STACK_REPLACEMENT;
3641 } 3640 }
3642 3641
3643 3642
3644 } // namespace internal 3643 } // namespace internal
3645 } // namespace v8 3644 } // namespace v8
3646 3645
3647 #endif // V8_TARGET_ARCH_X87 3646 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698