Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 } 257 }
258 258
259 // Possibly set up a local binding to the new target value. 259 // Possibly set up a local binding to the new target value.
260 Variable* new_target_var = info->scope()->new_target_var(); 260 Variable* new_target_var = info->scope()->new_target_var();
261 if (new_target_var != nullptr) { 261 if (new_target_var != nullptr) {
262 Comment cmnt(masm_, "[ new.target"); 262 Comment cmnt(masm_, "[ new.target");
263 SetVar(new_target_var, r5, r2, r4); 263 SetVar(new_target_var, r5, r2, r4);
264 } 264 }
265 265
266 // Possibly allocate RestParameters 266 // Possibly allocate RestParameters
267 int rest_index; 267 Variable* rest_param = info->scope()->rest_parameter();
268 Variable* rest_param = info->scope()->rest_parameter(&rest_index); 268 if (rest_param != nullptr) {
269 if (rest_param) {
270 Comment cmnt(masm_, "[ Allocate rest parameter array"); 269 Comment cmnt(masm_, "[ Allocate rest parameter array");
271 270
272 if (!function_in_register_r3) { 271 if (!function_in_register_r3) {
273 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 272 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
274 } 273 }
275 FastNewRestParameterStub stub(isolate()); 274 FastNewRestParameterStub stub(isolate());
276 __ CallStub(&stub); 275 __ CallStub(&stub);
277 276
278 function_in_register_r3 = false; 277 function_in_register_r3 = false;
279 SetVar(rest_param, r2, r3, r4); 278 SetVar(rest_param, r2, r3, r4);
(...skipping 3371 matching lines...) Expand 10 before | Expand all | Expand 10 after
3651 DCHECK(kOSRBranchInstruction == br_instr); 3650 DCHECK(kOSRBranchInstruction == br_instr);
3652 3651
3653 DCHECK(interrupt_address == 3652 DCHECK(interrupt_address ==
3654 isolate->builtins()->OnStackReplacement()->entry()); 3653 isolate->builtins()->OnStackReplacement()->entry());
3655 return ON_STACK_REPLACEMENT; 3654 return ON_STACK_REPLACEMENT;
3656 } 3655 }
3657 3656
3658 } // namespace internal 3657 } // namespace internal
3659 } // namespace v8 3658 } // namespace v8
3660 #endif // V8_TARGET_ARCH_S390 3659 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698