Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 SetVar(this_function_var, a1, a0, a2); 254 SetVar(this_function_var, a1, a0, a2);
255 } 255 }
256 256
257 Variable* new_target_var = info->scope()->new_target_var(); 257 Variable* new_target_var = info->scope()->new_target_var();
258 if (new_target_var != nullptr) { 258 if (new_target_var != nullptr) {
259 Comment cmnt(masm_, "[ new.target"); 259 Comment cmnt(masm_, "[ new.target");
260 SetVar(new_target_var, a3, a0, a2); 260 SetVar(new_target_var, a3, a0, a2);
261 } 261 }
262 262
263 // Possibly allocate RestParameters 263 // Possibly allocate RestParameters
264 int rest_index; 264 Variable* rest_param = info->scope()->rest_parameter();
265 Variable* rest_param = info->scope()->rest_parameter(&rest_index); 265 if (rest_param != nullptr) {
266 if (rest_param) {
267 Comment cmnt(masm_, "[ Allocate rest parameter array"); 266 Comment cmnt(masm_, "[ Allocate rest parameter array");
268 if (!function_in_register_a1) { 267 if (!function_in_register_a1) {
269 __ ld(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 268 __ ld(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
270 } 269 }
271 FastNewRestParameterStub stub(isolate()); 270 FastNewRestParameterStub stub(isolate());
272 __ CallStub(&stub); 271 __ CallStub(&stub);
273 function_in_register_a1 = false; 272 function_in_register_a1 = false;
274 SetVar(rest_param, v0, a1, a2); 273 SetVar(rest_param, v0, a1, a2);
275 } 274 }
276 275
(...skipping 3487 matching lines...) Expand 10 before | Expand all | Expand 10 after
3764 reinterpret_cast<uint64_t>( 3763 reinterpret_cast<uint64_t>(
3765 isolate->builtins()->OnStackReplacement()->entry())); 3764 isolate->builtins()->OnStackReplacement()->entry()));
3766 return ON_STACK_REPLACEMENT; 3765 return ON_STACK_REPLACEMENT;
3767 } 3766 }
3768 3767
3769 3768
3770 } // namespace internal 3769 } // namespace internal
3771 } // namespace v8 3770 } // namespace v8
3772 3771
3773 #endif // V8_TARGET_ARCH_MIPS64 3772 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698