Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 } 256 }
257 257
258 // Possibly set up a local binding to the new target value. 258 // Possibly set up a local binding to the new target value.
259 Variable* new_target_var = info->scope()->new_target_var(); 259 Variable* new_target_var = info->scope()->new_target_var();
260 if (new_target_var != nullptr) { 260 if (new_target_var != nullptr) {
261 Comment cmnt(masm_, "[ new.target"); 261 Comment cmnt(masm_, "[ new.target");
262 SetVar(new_target_var, a3, a0, a2); 262 SetVar(new_target_var, a3, a0, a2);
263 } 263 }
264 264
265 // Possibly allocate RestParameters 265 // Possibly allocate RestParameters
266 int rest_index; 266 Variable* rest_param = info->scope()->rest_parameter();
267 Variable* rest_param = info->scope()->rest_parameter(&rest_index); 267 if (rest_param != nullptr) {
268 if (rest_param) {
269 Comment cmnt(masm_, "[ Allocate rest parameter array"); 268 Comment cmnt(masm_, "[ Allocate rest parameter array");
270 if (!function_in_register_a1) { 269 if (!function_in_register_a1) {
271 __ lw(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 270 __ lw(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
272 } 271 }
273 FastNewRestParameterStub stub(isolate()); 272 FastNewRestParameterStub stub(isolate());
274 __ CallStub(&stub); 273 __ CallStub(&stub);
275 function_in_register_a1 = false; 274 function_in_register_a1 = false;
276 SetVar(rest_param, v0, a1, a2); 275 SetVar(rest_param, v0, a1, a2);
277 } 276 }
278 277
(...skipping 3478 matching lines...) Expand 10 before | Expand all | Expand 10 after
3757 reinterpret_cast<uint32_t>( 3756 reinterpret_cast<uint32_t>(
3758 isolate->builtins()->OnStackReplacement()->entry())); 3757 isolate->builtins()->OnStackReplacement()->entry()));
3759 return ON_STACK_REPLACEMENT; 3758 return ON_STACK_REPLACEMENT;
3760 } 3759 }
3761 3760
3762 3761
3763 } // namespace internal 3762 } // namespace internal
3764 } // namespace v8 3763 } // namespace v8
3765 3764
3766 #endif // V8_TARGET_ARCH_MIPS 3765 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698