Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 } 249 }
250 250
251 // Possibly set up a local binding to the new target value. 251 // Possibly set up a local binding to the new target value.
252 Variable* new_target_var = info->scope()->new_target_var(); 252 Variable* new_target_var = info->scope()->new_target_var();
253 if (new_target_var != nullptr) { 253 if (new_target_var != nullptr) {
254 Comment cmnt(masm_, "[ new.target"); 254 Comment cmnt(masm_, "[ new.target");
255 SetVar(new_target_var, x3, x0, x2); 255 SetVar(new_target_var, x3, x0, x2);
256 } 256 }
257 257
258 // Possibly allocate RestParameters 258 // Possibly allocate RestParameters
259 int rest_index; 259 Variable* rest_param = info->scope()->rest_parameter();
260 Variable* rest_param = info->scope()->rest_parameter(&rest_index); 260 if (rest_param != nullptr) {
261 if (rest_param) {
262 Comment cmnt(masm_, "[ Allocate rest parameter array"); 261 Comment cmnt(masm_, "[ Allocate rest parameter array");
263 if (!function_in_register_x1) { 262 if (!function_in_register_x1) {
264 __ Ldr(x1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 263 __ Ldr(x1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
265 } 264 }
266 FastNewRestParameterStub stub(isolate()); 265 FastNewRestParameterStub stub(isolate());
267 __ CallStub(&stub); 266 __ CallStub(&stub);
268 function_in_register_x1 = false; 267 function_in_register_x1 = false;
269 SetVar(rest_param, x0, x1, x2); 268 SetVar(rest_param, x0, x1, x2);
270 } 269 }
271 270
(...skipping 3554 matching lines...) Expand 10 before | Expand all | Expand 10 after
3826 } 3825 }
3827 3826
3828 return INTERRUPT; 3827 return INTERRUPT;
3829 } 3828 }
3830 3829
3831 3830
3832 } // namespace internal 3831 } // namespace internal
3833 } // namespace v8 3832 } // namespace v8
3834 3833
3835 #endif // V8_TARGET_ARCH_ARM64 3834 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698