Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2276873002: Replace 'eglGetCurrentContext()' with 'GetCurrent()' (Closed)

Created:
4 years, 4 months ago by penghu
Modified:
4 years, 3 months ago
Reviewers:
epenner, Wei Xiaohai, piman
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace 'eglGetCurrentContext()' with 'GetCurrent()'. An external eglcontext may be current on android webview. GetCurrent() is better than eglGetCurrentContext() here. BUG= Committed: https://crrev.com/b6f0461537316791d4faef5b27b348261629dc9b Cr-Commit-Position: refs/heads/master@{#414297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/gl/gl_context_egl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
penghu
4 years, 3 months ago (2016-08-25 01:07:34 UTC) #6
piman
lgtm
4 years, 3 months ago (2016-08-25 01:32:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276873002/1
4 years, 3 months ago (2016-08-25 01:41:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 03:49:32 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:51:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f0461537316791d4faef5b27b348261629dc9b
Cr-Commit-Position: refs/heads/master@{#414297}

Powered by Google App Engine
This is Rietveld 408576698