Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2276863002: Add navigation hint ServiceWorkerMetrics.EventType enums in histograms.xml (Closed)

Created:
4 years, 3 months ago by horo
Modified:
4 years, 3 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add navigation hint ServiceWorkerMetrics.EventType enums in histograms.xml I had to add them in https://codereview.chromium.org/2052613003 BUG=616502 Committed: https://crrev.com/a7e7439065dd32570ac2aabaf5557470294a43c0 Cr-Commit-Position: refs/heads/master@{#414363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
horo
mpearson@ Please review this.
4 years, 3 months ago (2016-08-24 06:44:16 UTC) #3
Mark P
lgtm
4 years, 3 months ago (2016-08-24 20:56:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276863002/1
4 years, 3 months ago (2016-08-24 22:20:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280516)
4 years, 3 months ago (2016-08-25 01:12:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276863002/1
4 years, 3 months ago (2016-08-25 05:08:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 08:36:38 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 08:37:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7e7439065dd32570ac2aabaf5557470294a43c0
Cr-Commit-Position: refs/heads/master@{#414363}

Powered by Google App Engine
This is Rietveld 408576698