[ash-md] Does not cancel overview when focus shifts from text fitler

ash/common/wm/overview/window_selector.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/overview/window_selector.h"
 
 #include <algorithm>
 #include <functional>
 #include <set>
 #include <utility>
@@ skipping 591 matching lines @@
   auto grid =
       std::find_if(grid_list_.begin(), grid_list_.end(),
                    RootWindowGridComparator(gained_active->GetRootWindow()));
   if (grid == grid_list_.end())
     return;
   const std::vector<WindowSelectorItem*> windows = (*grid)->window_list();
 
   auto iter = std::find_if(windows.begin(), windows.end(),
                            WindowSelectorItemTargetComparator(gained_active));
 
-  if (iter != windows.end())
+  if (iter != windows.end()) {
     (*iter)->ShowWindowOnExit();
+  } else if (showing_selection_widget_ &&

[tdanderson, 2016/08/24 14:49:25]

What if the string entered into the text filter widget does not match any window
titles - won't |showing_selection_widget_| be false in that case?

[varkha, 2016/08/24 16:53:54]

No. |showing_selection_widget_| is indicating visibility of the text filter
rather than "selection widget" (aka WindowGrid::selection_widget_|. Name reuse I
guess. I will rename the variable to reflect that.

[tdanderson, 2016/08/24 17:43:52]

Thanks.

+             lost_active == GetTextFilterWidgetWindow()) {
+    return;
+  }
 
   // Don't restore focus on exit if a window was just activated.
   ResetFocusRestoreWindow(false);
   CancelSelection();
 }
 
 void WindowSelector::OnAttemptToReactivateWindow(WmWindow* request_active,
                                                  WmWindow* actual_active) {
   OnWindowActivated(request_active, actual_active);
 }
@@ skipping 90 matching lines @@
   for (size_t i = 0; i <= grid_list_.size() &&
                      grid_list_[selected_grid_index_]->Move(direction, animate);
        i++) {
     selected_grid_index_ =
         (selected_grid_index_ + display_direction + grid_list_.size()) %
         grid_list_.size();
   }
 }
 
 }  // namespace ash