Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 227683006: Remove ImageTransportFactory::CreateTransportClient (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Remove ImageTransportFactory::CreateTransportClient It's not used any more. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262489

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use GLuint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -109 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/compositor/image_transport_factory_browsertest.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download
M content/browser/compositor/no_transport_image_transport_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/no_transport_image_transport_factory.cc View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
piman
6 years, 8 months ago (2014-04-07 19:23:51 UTC) #1
danakj
LGTM https://codereview.chromium.org/227683006/diff/1/content/browser/compositor/image_transport_factory_browsertest.cc File content/browser/compositor/image_transport_factory_browsertest.cc (right): https://codereview.chromium.org/227683006/diff/1/content/browser/compositor/image_transport_factory_browsertest.cc#newcode44 content/browser/compositor/image_transport_factory_browsertest.cc:44: unsigned int texture_id = 0; nit: uint32?
6 years, 8 months ago (2014-04-08 14:34:18 UTC) #2
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-08 17:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/227683006/20001
6 years, 8 months ago (2014-04-08 17:30:08 UTC) #4
piman
https://codereview.chromium.org/227683006/diff/1/content/browser/compositor/image_transport_factory_browsertest.cc File content/browser/compositor/image_transport_factory_browsertest.cc (right): https://codereview.chromium.org/227683006/diff/1/content/browser/compositor/image_transport_factory_browsertest.cc#newcode44 content/browser/compositor/image_transport_factory_browsertest.cc:44: unsigned int texture_id = 0; On 2014/04/08 14:34:18, danakj ...
6 years, 8 months ago (2014-04-08 17:34:22 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 19:57:59 UTC) #6
Message was sent while issue was closed.
Change committed as 262489

Powered by Google App Engine
This is Rietveld 408576698