Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: runtime/lib/typed_data.cc

Issue 2276803002: Remove unused external typed data factories. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typed_data.cc
diff --git a/runtime/lib/typed_data.cc b/runtime/lib/typed_data.cc
index 8d39988f1f304cc0b57ff0352fb44ccbddcd15a0..4130e60fba2f74fd5257a46087b40ce8ac4b69d1 100644
--- a/runtime/lib/typed_data.cc
+++ b/runtime/lib/typed_data.cc
@@ -41,13 +41,6 @@ static void LengthCheck(intptr_t len, intptr_t max) {
}
-static void PeerFinalizer(void* isolate_callback_data,
- Dart_WeakPersistentHandle handle,
- void* peer) {
- OS::AlignedFree(peer);
-}
-
-
DEFINE_NATIVE_ENTRY(TypedData_length, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Instance, instance, arguments->NativeArgAt(0));
if (instance.IsTypedData()) {
@@ -175,31 +168,8 @@ DEFINE_NATIVE_ENTRY(TypedData_##name##_new, 2) { \
} \
-// We check the length parameter against a possible maximum length for the
-// array based on available physical addressable memory on the system. The
-// maximum possible length is a scaled value of kSmiMax which is set up based
-// on whether the underlying architecture is 32-bit or 64-bit.
-// Argument 0 is type arguments and is ignored.
-#define EXT_TYPED_DATA_NEW(name) \
-DEFINE_NATIVE_ENTRY(ExternalTypedData_##name##_new, 2) { \
- const int kAlignment = 16; \
- GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(1)); \
- intptr_t cid = kExternalTypedData##name##Cid; \
- intptr_t len = length.Value(); \
- intptr_t max = ExternalTypedData::MaxElements(cid); \
- LengthCheck(len, max); \
- intptr_t len_bytes = len * ExternalTypedData::ElementSizeInBytes(cid); \
- uint8_t* data = OS::AllocateAlignedArray<uint8_t>(len_bytes, kAlignment); \
- const ExternalTypedData& obj = \
- ExternalTypedData::Handle(ExternalTypedData::New(cid, data, len)); \
- obj.AddFinalizer(data, PeerFinalizer); \
- return obj.raw(); \
-} \
-
-
#define TYPED_DATA_NEW_NATIVE(name) \
TYPED_DATA_NEW(name) \
- EXT_TYPED_DATA_NEW(name) \
CLASS_LIST_TYPED_DATA(TYPED_DATA_NEW_NATIVE)
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698