Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2276803002: Remove unused external typed data factories. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -227 lines) Patch
M runtime/lib/typed_data.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M runtime/lib/typed_data.dart View 14 chunks +0 lines, -56 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M runtime/vm/os_test.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-24 17:50:09 UTC) #2
Cutch
LGTM
4 years, 4 months ago (2016-08-24 18:25:57 UTC) #3
rmacnak
4 years, 3 months ago (2016-08-25 17:29:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c06127e2d73a429bb10fd7872a1116677116d3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698