Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 2276733003: Issue 27133. Reset AnalysisDriver when performing limited invalidation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 22ac5e57927c2a9572a9f9946c448dbf14a3e678..55cd2c81c8991858a4f67658eeb2a134e96b55d3 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -1856,6 +1856,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
return;
}
+ // We're going to update the cache, so reset the driver.
+ driver.reset();
+
// We need to invalidate the cache.
{
if (analysisOptions.finerGrainedInvalidation &&
@@ -1898,7 +1901,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
entry.setState(MODIFICATION_TIME, CacheState.INVALID);
entry.setState(SOURCE_KIND, CacheState.INVALID);
}
- driver.reset();
for (WorkManager workManager in workManagers) {
workManager.applyChange(
Source.EMPTY_LIST, <Source>[source], Source.EMPTY_LIST);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698