Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2276733002:
v8.gyp: fix mkpeephole on Windows for Node.js (Closed)
Descriptionv8.gyp: fix mkpeephole on Windows for Node.js
The mkpeephole step was failing on Windows (only) for Node.js [1].
It seems that gyp was not creating the dependency graph correctly for
Windows. Work-around the problem by exposing the dependency directly
(as opposed to exposing it in the action), similar to how `mksnapshot`
works.
[1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console
R=oth@chromium.org, rmcilroy@chromium.org
BUG=
Committed: https://crrev.com/fcc8399d390951dc519588924dfa74a93fd2198e
Cr-Commit-Position: refs/heads/master@{#38869}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by ofrobots@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ========== to ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph incorrectly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ==========
Description was changed from ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph incorrectly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ========== to ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks Ali! I'm guessing this is only an issue with GYP and the GN build would work for Node.js (assuming Node can use the GN build)?
On 2016/08/24 10:17:17, rmcilroy wrote: > LGTM, thanks Ali! I'm guessing this is only an issue with GYP and the GN build > would work for Node.js (assuming Node can use the GN build)? Thanks. Node doesn't build with GN at this point.
The CQ bit was checked by ofrobots@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ========== to ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= ========== to ========== v8.gyp: fix mkpeephole on Windows for Node.js The mkpeephole step was failing on Windows (only) for Node.js [1]. It seems that gyp was not creating the dependency graph correctly for Windows. Work-around the problem by exposing the dependency directly (as opposed to exposing it in the action), similar to how `mksnapshot` works. [1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console R=oth@chromium.org, rmcilroy@chromium.org BUG= Committed: https://crrev.com/fcc8399d390951dc519588924dfa74a93fd2198e Cr-Commit-Position: refs/heads/master@{#38869} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fcc8399d390951dc519588924dfa74a93fd2198e Cr-Commit-Position: refs/heads/master@{#38869}
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
This CL broke our mips builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder... Could you fix that one too?
Message was sent while issue was closed.
akos.palfi@imgtec.com changed reviewers: + akos.palfi@imgtec.com
Message was sent while issue was closed.
@ofrobots, @machenbach: I've uploaded a fix for the mips build problem, however, I'm not sure it this is acceptable or correct solution. Note that I've not tested it on Windows/Node.js. PTAL: https://codereview.chromium.org/2296473002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
