Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 227673007: Revert r245379 Add missing test targets to chrome_official_builder for Windows (Closed)

Created:
6 years, 8 months ago by jschuh
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert r245379 Add missing test targets to chrome_official_builder for Windows These were removed because they break parts of the official build BUG=334006 R=scottmg,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262252

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : remoting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M build/all.gyp View 1 2 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
LGTM otherwise. https://codereview.chromium.org/227673007/diff/1/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/227673007/diff/1/build/all.gyp#oldcode1093 build/all.gyp:1093: 'target_name': 'chrome_official_builder', Please add a comment as ...
6 years, 8 months ago (2014-04-07 23:28:58 UTC) #1
iannucci
lgtm
6 years, 8 months ago (2014-04-07 23:39:36 UTC) #2
jschuh
https://codereview.chromium.org/227673007/diff/1/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/227673007/diff/1/build/all.gyp#oldcode1093 build/all.gyp:1093: 'target_name': 'chrome_official_builder', On 2014/04/07 23:28:58, scottmg wrote: > Please ...
6 years, 8 months ago (2014-04-07 23:40:01 UTC) #3
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 8 months ago (2014-04-07 23:43:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/227673007/10002
6 years, 8 months ago (2014-04-07 23:45:30 UTC) #5
commit-bot: I haz the power
Change committed as 262252
6 years, 8 months ago (2014-04-07 23:47:10 UTC) #6
jschuh
6 years, 8 months ago (2014-04-08 00:06:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/227703011/ by jschuh@chromium.org.

The reason for reverting is: The release team owns these tests now..

Powered by Google App Engine
This is Rietveld 408576698