Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 227673005: make CT skia_try_server work with updated render_pictures JSON (Closed)

Created:
6 years, 8 months ago by epoger
Modified:
6 years, 8 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

make CT skia_try_server work with updated render_pictures JSON needed to stay in sync with https://codereview.chromium.org/226293002 BUG=skia:2230 NOTREECHECKS=True NOTRY=True Committed: https://skia.googlesource.com/buildbot/+/9f8d1f8fe5387a78a145e4626193f081c5e89529

Patch Set 1 #

Total comments: 1

Patch Set 2 : renumber tiles (tile2->tile0, tile3->tile1) in unittest #

Patch Set 3 : update input testdata to match CL 226293002 patchset 5 #

Patch Set 4 : properly handle updated input testdata #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -75 lines) Patch
M compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/output1.json View 1 2 1 chunk +24 lines, -15 lines 0 comments Download
M compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/output2.json View 1 2 1 chunk +24 lines, -15 lines 0 comments Download
M compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json View 1 1 chunk +18 lines, -18 lines 0 comments Download
M compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py View 1 2 3 4 chunks +89 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
PTAL https://codereview.chromium.org/227673005/diff/1/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py File compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py (right): https://codereview.chromium.org/227673005/diff/1/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py#newcode155 compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py:155: return re.sub('-tile\d+$', '', skp_file_and_tile) This still relies on ...
6 years, 8 months ago (2014-04-07 22:08:00 UTC) #1
epoger
Ravi- Please review at patchset 4. The unittests and implementation are now up-to-date with the ...
6 years, 8 months ago (2014-04-09 20:33:04 UTC) #2
rmistry
LGTM
6 years, 8 months ago (2014-04-10 11:47:58 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-10 15:37:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/227673005/70001
6 years, 8 months ago (2014-04-10 15:37:13 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 15:37:20 UTC) #6
Message was sent while issue was closed.
Change committed as 9f8d1f8fe5387a78a145e4626193f081c5e89529

Powered by Google App Engine
This is Rietveld 408576698