Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

Issue 2276713002: Remove Command.bind_to_tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
index a9264ebf8a122cd349bcaa7d34ab977226db0ddf..5a2896b480b334f0ceed4d06fbd653df4e7e6139 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
@@ -47,7 +47,6 @@ class Command(object):
self.required_arguments = self._parse_required_arguments(self.argument_names)
self.options = options
self.requires_local_commits = requires_local_commits
- self._tool = None
# option_parser can be overridden by the tool using set_option_parser
# This default parser will be used for standalone_help printing.
self.option_parser = HelpPrintingOptionParser(
@@ -70,13 +69,6 @@ class Command(object):
for option in options:
self.option_parser.add_option(option)
- # The tool calls bind_to_tool on each Command after adding it to its list.
- def bind_to_tool(self, tool):
- # Command instances can only be bound to one tool at a time.
- if self._tool and tool != self._tool:
- raise Exception("Command already bound to tool!")
- self._tool = tool
-
@staticmethod
def _parse_required_arguments(argument_names):
required_args = []

Powered by Google App Engine
This is Rietveld 408576698