Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: build/android/pylib/gtest/test_runner.py

Issue 22767002: [Android] Clear gtest app's data on tear down. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_runner.py
diff --git a/build/android/pylib/gtest/test_runner.py b/build/android/pylib/gtest/test_runner.py
index 70d393c9abf24c076a106390e599fac3e5a1374e..201e1acabc5816c72313c1fc16333d42a7100abb 100644
--- a/build/android/pylib/gtest/test_runner.py
+++ b/build/android/pylib/gtest/test_runner.py
@@ -160,12 +160,17 @@ class TestRunner(base_test_runner.BaseTestRunner):
return test_results, None
try:
- self.test_package.ClearApplicationState(self.adb)
self.test_package.CreateCommandLineFileOnDevice(
self.adb, test, self._test_arguments)
test_results = self._ParseTestOutput(
self.test_package.SpawnTestProcess(self.adb))
finally:
+ self.test_package.ClearApplicationState(self.adb)
craigdh 2013/08/12 16:11:06 It's now possible the tests start with some applic
frankf 2013/08/12 18:17:21 I removed the precondition assumption. Now we clea
+ # Content shell creates a profile on the sdscard which accumulates cache
+ # files over time.
+ self.adb.RunShellCommand('rm -r ' +
+ os.path.join(self.adb.GetExternalStorage(), 'content_shell'),
+ timeout_time=60 * 2)
self.CleanupSpawningServerState()
# Calculate unknown test results.
all_tests = set(test.split(':'))
@@ -188,10 +193,5 @@ class TestRunner(base_test_runner.BaseTestRunner):
#override
def TearDown(self):
"""Cleans up the test enviroment for the test suite."""
- # Content shell creates a profile on the sdscard which accumulates cache
- # files over time.
- self.adb.RunShellCommand('rm -r ' +
- os.path.join(self.adb.GetExternalStorage(), 'content_shell'),
- timeout_time=60 * 2)
self.tool.CleanUpEnvironment()
super(TestRunner, self).TearDown()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698