Issue 22767002: [Android] Clear gtest app's data on tear down.

Issue 22767002: [Android] Clear gtest app's data on tear down. (Closed)

Created:
7 years, 4 months ago by frankf

Modified:
7 years, 4 months ago

Reviewers:
craigdh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Clear gtest app's data on tear down. This also closes the app. If the app crashes in the background, it might interfere with subsequent instrumentation tests. BUG=271071 R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217065

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	build/android/pylib/gtest/test_package_apk.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	build/android/pylib/gtest/test_runner.py	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

https://codereview.chromium.org/22767002/diff/4001/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/22767002/diff/4001/build/android/pylib/gtest/test_runner.py#newcode168 build/android/pylib/gtest/test_runner.py:168: self.test_package.ClearApplicationState(self.adb) It's now possible the tests start with some ...

7 years, 4 months ago (2013-08-12 16:11:06 UTC) #2

frankf

ptal https://codereview.chromium.org/22767002/diff/4001/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/22767002/diff/4001/build/android/pylib/gtest/test_runner.py#newcode168 build/android/pylib/gtest/test_runner.py:168: self.test_package.ClearApplicationState(self.adb) I removed the precondition assumption. Now we ...

7 years, 4 months ago (2013-08-12 18:17:21 UTC) #3

frankf

On 2013/08/12 18:20:36, craigdh wrote: > lgtm. Failure on adroid_fyi_dbg is unrelated to this patch.

7 years, 4 months ago (2013-08-12 20:44:10 UTC) #5

frankf

7 years, 4 months ago (2013-08-12 20:48:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r217065 (presubmit successful).

Expand Messages | Collapse Messages