Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2276663002: git cl archive: Add "--dry-run" and "--notags" flags. (Closed)

Created:
4 years, 4 months ago by Kevin M
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl archive: Add "--dry-run" and "--notags" flags. This CL adds a couple flags to "git cl archive". dry-run: Lists the cleanup tasks, but exits before any changes are made to Git. notags: Deletes branches only; does not create archival tags. R=tandrii@chromium.org,groby@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9249e01b702c6fe86f089ae0a8769a0f673b4a93

Patch Set 1 #

Total comments: 1

Patch Set 2 : test copypasta--; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -31 lines) Patch
M git_cl.py View 2 chunks +26 lines, -9 lines 0 comments Download
M tests/git_cl_test.py View 1 3 chunks +57 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Kevin M
4 years, 4 months ago (2016-08-23 18:10:19 UTC) #1
groby-ooo-7-16
You are awesome and you should feel awesome! Thank you! LGTM
4 years, 4 months ago (2016-08-23 18:30:27 UTC) #2
tandrii(chromium)
(LGTM + awesome feature + awesome tests) % (1 comment) https://codereview.chromium.org/2276663002/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/2276663002/diff/1/tests/git_cl_test.py#newcode1760 ...
4 years, 4 months ago (2016-08-23 18:41:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276663002/20001
4 years, 4 months ago (2016-08-23 18:58:11 UTC) #6
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-08-23 18:59:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/9249e01b702c6fe86f089ae0a8769a0f673b4a93
4 years, 4 months ago (2016-08-23 19:02:24 UTC) #9
Kevin M
4 years, 4 months ago (2016-08-23 21:33:12 UTC) #10
Message was sent while issue was closed.
Thanks for the compliments! :)

Powered by Google App Engine
This is Rietveld 408576698