components/policy/core/common/cloud/cloud_policy_client.cc - Issue 2276593004: Device registration using an enrollment certificate from the PCA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_client.cc

Issue 2276593004: Device registration using an enrollment certificate from the PCA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into register-with-certificate Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_cloud_policy_initializer.h ('K') | « components/policy/core/common/cloud/cloud_policy_client.h ('k') | components/policy/core/common/cloud/cloud_policy_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_client.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_client.cc b/components/policy/core/common/cloud/cloud_policy_client.cc

index 57d12c240004cb750d11a26a0cb138c64a1ad6b3..c122da2d9d2b566789c1092e85d376c82481a4ad 100644

--- a/components/policy/core/common/cloud/cloud_policy_client.cc

+++ b/components/policy/core/common/cloud/cloud_policy_client.cc

@@ -12,6 +12,7 @@

#include "base/logging.h"

#include "base/stl_util.h"

#include "components/policy/core/common/cloud/device_management_service.h"

+#include "components/policy/core/common/cloud/signing_service.h"

#include "google_apis/gaia/gaia_constants.h"

#include "google_apis/gaia/gaia_urls.h"

#include "net/url_request/url_request_context_getter.h"

@@ -271,13 +272,10 @@ void CloudPolicyClient::FetchPolicy() {

void CloudPolicyClient::FetchRobotAuthCodes(const std::string& auth_token) {

CHECK(is_registered());

- DCHECK(!auth_token.empty());

policy_fetch_request_job_.reset(service_->CreateJob(

DeviceManagementRequestJob::TYPE_API_AUTH_CODE_FETCH,

GetRequestContext()));

- // The credentials of a domain user are needed in order to mint a new OAuth2

- // authorization token for the robot account.

policy_fetch_request_job_->SetOAuthToken(auth_token);

policy_fetch_request_job_->SetDMToken(dm_token_);

policy_fetch_request_job_->SetClientID(client_id_);