third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h - Issue 2276593002: Support renaming of IndexedDB indexes and object stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

Issue 2276593002: Support renaming of IndexedDB indexes and object stores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test coverage for the (slightly incorrect) behavior in strict mode when our flag is not enabl… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html ('K') | « third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

index 3fba56d85eb993ca4af55c2eae08c329e3e573f6..b33f6771da6d6a28e45026ce0bc6fbf7b4b0a0b4 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

@@ -49,6 +49,7 @@ public:

virtual void createObjectStore(long long transactionId, long long objectStoreId, const WebString& name, const WebIDBKeyPath&, bool autoIncrement) = 0;

virtual void deleteObjectStore(long long transactionId, long long objectStoreId) = 0;

+ virtual void renameObjectStore(long long transactionId, long long objectStoreId, const WebString& name) = 0;

virtual void createTransaction(long long id, WebIDBDatabaseCallbacks*, const WebVector<long long>& scope, WebIDBTransactionMode) = 0;

virtual void close() = 0;

virtual void versionChangeIgnored() = 0;

@@ -58,6 +59,7 @@ public:

virtual void createIndex(long long transactionId, long long objectStoreId, long long indexId, const WebString& name, const WebIDBKeyPath&, bool unique, bool multiEntry) = 0;

virtual void deleteIndex(long long transactionId, long long objectStoreId, long long indexId) = 0;

+ virtual void renameIndex(long long transactionId, long long objectStoreId, long long indexId, const WebString& newName) = 0;

static const long long minimumIndexId = 30;