Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-errors.html

Issue 2276593002: Support renaming of IndexedDB indexes and object stores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test coverage for the (slightly incorrect) behavior in strict mode when our flag is not enabl… Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/rename-index.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store.html » ('j') | third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-errors.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-errors.html b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-errors.html
new file mode 100644
index 0000000000000000000000000000000000000000..adab76924106557244ce53ba3f9f84532c7364eb
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-errors.html
@@ -0,0 +1,130 @@
+<!DOCTYPE html>
+<title>IndexedDB: index renaming error handling</title>
+<script src='../../resources/testharness.js'></script>
+<link rel="help"
+ href="https://w3c.github.io/IndexedDB/#dom-idbindex-name">
+<link rel="author" href="pwnall@chromium.org" title="Victor Costan">
+<script src='../../resources/testharnessreport.js'></script>
+<script src='resources/rename-common.js'></script>
+<script>
+
+promise_test(testCase => {
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ const store = transaction.objectStore('books');
+ const index = store.index('by_author');
+ store.deleteIndex('by_author');
+ assert_throws(
+ 'InvalidStateError', () => index.name = 'renamed_by_author');
+ })).then(database => database.close());
+}, 'IndexedDB deleted index rename throws');
+
+promise_test(testCase => {
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ const transaction = database.transaction('books', 'readonly');
+ const store = transaction.objectStore('books');
+ const index = store.index('by_author');
+
+ assert_throws(
+ 'InvalidStateError', () => index.name = 'renamed_by_author');
+ database.close();
+ });
+}, 'IndexedDB index rename throws in a readonly transaction');
+
+promise_test(testCase => {
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ const transaction = database.transaction('books', 'readwrite');
+ const store = transaction.objectStore('books');
+ const index = store.index('by_author');
+
+ assert_throws(
+ 'InvalidStateError', () => index.name = 'renamed_by_author');
+ database.close();
+ });
+}, 'IndexedDB index rename throws in a readwrite transaction');
+
+promise_test(testCase => {
+ let authorIndex = null;
+ return createDatabase(testCase, (database, transaction) => {
+ const store = createBooksStore(testCase, database);
+ authorIndex = store.index('by_author');
+ }).then(database => {
+ assert_throws(
+ 'TransactionInactiveError',
+ () => authorIndex.name = 'renamed_by_author');
+ database.close();
+ });
+}, 'IndexedDB index rename throws in an inactive transaction');
+
+promise_test(testCase => {
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ const store = transaction.objectStore('books');
+ const index = store.index('by_author');
+
+ assert_throws('ConstraintError', () => index.name = 'by_title');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'An index rename that throws an exception should not change the ' +
+ "index's IDBObjectStore.indexNames");
+ })).then(database => {
+ const transaction = database.transaction('books', 'readonly');
+ const store = transaction.objectStore('books');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'Committing a transaction with a failed store rename attempt ' +
+ "should not change the index's IDBObjectStore.indexNames");
+ const index = store.index('by_author');
+ return checkAuthorIndexContents(
+ testCase, index,
+ 'Committing a transaction with a failed rename attempt should ' +
+ "not change the index's contents").then(() => database.close());
+ });
+}, 'IndexedDB index rename to the name of another index throws');
+
+promise_test(testCase => {
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ const store = transaction.objectStore('books');
+ const index = store.index('by_author');
+
+ assert_throws(
+ { name: 'Custom stringifying error' },
+ () => {
+ index.name = {
+ toString: () => { throw { name: 'Custom stringifying error'}; }
+ };
+ }, 'IDBObjectStore rename should re-raise toString() exception');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'An index rename that throws an exception should not change the ' +
+ "index's IDBObjectStore.indexNames");
+ })).then(database => {
+ const transaction = database.transaction('books', 'readonly');
+ const store = transaction.objectStore('books');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'Committing a transaction with a failed store rename attempt ' +
+ "should not change the index's IDBObjectStore.indexNames");
+ const index = store.index('by_author');
+ return checkAuthorIndexContents(
+ testCase, index,
+ 'Committing a transaction with a failed rename attempt should ' +
+ "not change the index's contents").then(() => database.close());
+ });
+}, 'IndexedDB index rename handles exceptions when stringifying names');
+
+</script>
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/rename-index.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store.html » ('j') | third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698