content/child/indexed_db/webidbdatabase_impl.h - Issue 2276593002: Support renaming of IndexedDB indexes and object stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/indexed_db/webidbdatabase_impl.h

Issue 2276593002: Support renaming of IndexedDB indexes and object stores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test coverage for the (slightly incorrect) behavior in strict mode when our flag is not enabl… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_fake_backing_store.cc ('k') | content/child/indexed_db/webidbdatabase_impl.cc » ('j') | third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/indexed_db/webidbdatabase_impl.h

diff --git a/content/child/indexed_db/webidbdatabase_impl.h b/content/child/indexed_db/webidbdatabase_impl.h

index 85710030a8b3778bfbbafed2e865ee2a97b61ab6..5f51df20dd2413ed21ae530fff9a6cd37da23d5f 100644

--- a/content/child/indexed_db/webidbdatabase_impl.h

+++ b/content/child/indexed_db/webidbdatabase_impl.h

@@ -40,6 +40,9 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

bool auto_increment) override;

void deleteObjectStore(long long transaction_id,

long long object_store_id) override;

+ void renameObjectStore(long long transaction_id,

+ long long object_store_id,

+ const blink::WebString& new_name) override;

void createTransaction(long long transaction_id,

blink::WebIDBDatabaseCallbacks* callbacks,

const blink::WebVector<long long>& scope,

@@ -113,6 +116,10 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

void deleteIndex(long long transactionId,

long long objectStoreId,

long long indexId) override;

+ void renameIndex(long long transactionId,

+ long long objectStoreId,

+ long long indexId,

+ const blink::WebString& new_name) override;

void abort(long long transaction_id) override;

void commit(long long transaction_id) override;

void ackReceivedBlobs(