content/browser/indexed_db/indexed_db_fake_backing_store.h - Issue 2276593002: Support renaming of IndexedDB indexes and object stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_fake_backing_store.h

Issue 2276593002: Support renaming of IndexedDB indexes and object stores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test coverage for the (slightly incorrect) behavior in strict mode when our flag is not enabl… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_dispatcher_host.cc ('k') | content/browser/indexed_db/indexed_db_fake_backing_store.cc » ('j') | third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_fake_backing_store.h

diff --git a/content/browser/indexed_db/indexed_db_fake_backing_store.h b/content/browser/indexed_db/indexed_db_fake_backing_store.h

index 70be7dc681fc44516018a67426717c939a4ce125..636302419bd4c11feb26f3c07e26fcdbb5837431 100644

--- a/content/browser/indexed_db/indexed_db_fake_backing_store.h

+++ b/content/browser/indexed_db/indexed_db_fake_backing_store.h

@@ -48,6 +48,10 @@ class IndexedDBFakeBackingStore : public IndexedDBBackingStore {

leveldb::Status DeleteObjectStore(Transaction* transaction,

int64_t database_id,

int64_t object_store_id) override;

+ leveldb::Status RenameObjectStore(Transaction* transaction,

+ int64_t database_id,

+ int64_t object_store_id,

+ const base::string16& name) override;

leveldb::Status PutRecord(

IndexedDBBackingStore::Transaction* transaction,

@@ -96,6 +100,11 @@ class IndexedDBFakeBackingStore : public IndexedDBBackingStore {

int64_t database_id,

int64_t object_store_id,

int64_t index_id) override;

+ leveldb::Status RenameIndex(Transaction*,

+ int64_t database_id,

+ int64_t object_store_id,

+ int64_t index_id,

+ const base::string16& new_name) override;

leveldb::Status PutIndexDataForRecord(Transaction*,

int64_t database_id,

int64_t object_store_id,