Support renaming of IndexedDB indexes and object stores.

third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 53 matching lines @@
     ASSERT(m_transaction);
 }
 
 DEFINE_TRACE(IDBObjectStore)
 {
     visitor->trace(m_transaction);
     visitor->trace(m_indexMap);
     visitor->trace(m_createdIndexes);
 }
 
+void IDBObjectStore::setName(const String& name, ExceptionState& exceptionState)
+{
+    IDB_TRACE("IDBObjectStore::setName");
+    if (!m_transaction->isVersionChange()) {
+        exceptionState.throwDOMException(InvalidStateError, IDBDatabase::notVersionChangeTransactionErrorMessage);

[jsbell, 2016/08/26 23:20:50]

FYI, we have a generic storage/indexeddb/exceptions.html test that exercises
various exception cases. Could add cases there if they're not covered by
dedicated tests.

[pwnall, 2016/08/29 19:24:12]

I think the Web Platform layout tests I wrote cover all the branches, but I
haven't covered the exception messages. I think that needs to happen in a
separate test that can't be upstreamed, because AFAIK messages aren't
standardized.

+        return;
+    }
+    if (isDeleted()) {
+        exceptionState.throwDOMException(InvalidStateError, IDBDatabase::objectStoreDeletedErrorMessage);
+        return;
+    }
+    if (m_transaction->isFinished() || m_transaction->isFinishing()) {
+        exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionFinishedErrorMessage);
+        return;
+    }
+    if (!m_transaction->isActive()) {
+        exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionInactiveErrorMessage);
+        return;
+    }
+
+    if (m_transaction->db()->containsObjectStore(name)) {

[jsbell, 2016/08/26 23:20:50]

Do we need a special case for `store.name = store.name;` ?

Spec has: If store’s name is equal to name, terminate these steps.

[pwnall, 2016/08/29 19:24:12]

Yes, we do :)

The code here doesn't pass the tests yet. Now that I have the tests, I'll use
them to drive the implementation.

+        exceptionState.throwDOMException(ConstraintError, "An object store with the specified name already exists.");
+        return;
+    }
+    if (!backendDB()) {
+        exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databaseClosedErrorMessage);
+        return;
+    }
+
+    m_metadata.name = name;
+}
+
 ScriptValue IDBObjectStore::keyPath(ScriptState* scriptState) const
 {
     return ScriptValue::from(scriptState, m_metadata.keyPath);
 }
 
 DOMStringList* IDBObjectStore::indexNames() const
 {
     IDB_TRACE("IDBObjectStore::indexNames");
     DOMStringList* indexNames = DOMStringList::create(DOMStringList::IndexedDB);
     for (const auto& it : m_metadata.indexes)
@@ skipping 675 matching lines @@
     }
     return IDBIndexMetadata::InvalidId;
 }
 
 WebIDBDatabase* IDBObjectStore::backendDB() const
 {
     return m_transaction->backendDB();
 }
 
 } // namespace blink