third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html - Issue 2276593002: Support renaming of IndexedDB indexes and object stores.

Side by Side Diff: third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed.html

Issue 2276593002: Support renaming of IndexedDB indexes and object stores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor comment fixes in rename-common.js test code. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt ('k') | third_party/WebKit/LayoutTests/webexposed/indexeddb-renames-should-not-be-exposed-expected.txt » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../resources/testharness.js'></script>

	3 <script src='../resources/testharnessreport.js'></script>

	4 <script>

	5

	6 // This test makes sure that the IndexedDB object store and index name setters

	7 // are only exposed when the experimental Web Platform features flag is set.

	8 // This is implemented in Blink because our bindings generator does not support

	9 // separate settings for exposing a property's getter and setter.

	10 //

	11 // TODO(crbug.com/644889): Remove this test after we ship IndexedDB v2.

	12

	13 async_test(testCase => {
	foolip 2016/09/09 08:12:17 FWIW, in upstream web-platform-tests, this seems t FWIW, in upstream web-platform-tests, this seems to be called either test or just t, or alternatively one can use this throughout, as the method is invoked with the test as the this value. Not sure if that works with arrow functions though. pwnall 2016/09/09 20:50:34 Done. I used t, though it doesn't mesh well with Show quoted text On 2016/09/09 08:12:17, foolip wrote: > FWIW, in upstream web-platform-tests, this seems to be called either test or > just t, or alternatively one can use this throughout, as the method is invoked > with the test as the this value. Not sure if that works with arrow functions > though. Done. I used t, though it doesn't mesh well with my short memory :) In arrow functions, this has the same value as when the function is defined. I the fancy speak for this is -- "this" is lexically bound. foolip 2016/09/09 22:31:17 Right, so it wouldn't work to use only arrow funct Show quoted text On 2016/09/09 20:50:34, pwnall wrote: > On 2016/09/09 08:12:17, foolip wrote: > > FWIW, in upstream web-platform-tests, this seems to be called either test or > > just t, or alternatively one can use this throughout, as the method is invoked > > with the test as the this value. Not sure if that works with arrow functions > > though. > > Done. > > I used t, though it doesn't mesh well with my short memory :) > > In arrow functions, this has the same value as when the function is defined. I > the fancy speak for this is -- "this" is lexically bound. Right, so it wouldn't work to use only arrow functions. Anyway, doesn't matter.
	14 const dbName = 'db' + self.location.pathname + '-' + testCase.name;
	foolip 2016/09/09 08:12:17 Looks like the web platform is missing an mktemp f Looks like the web platform is missing an mktemp for databases :) pwnall 2016/09/09 20:50:34 What it really needs is a makeAllMyTestsPass() :D Show quoted text On 2016/09/09 08:12:17, foolip wrote: > Looks like the web platform is missing an mktemp for databases :) What it really needs is a makeAllMyTestsPass() :D Seriously though, this approach has the benefit that the database name is deterministic and based on the test case. When debugging, this makes it easy to find the database for the test in the dev tools / inspector, and look at its contents. foolip 2016/09/09 22:31:17 Acknowledged. Show quoted text On 2016/09/09 20:50:34, pwnall wrote: > On 2016/09/09 08:12:17, foolip wrote: > > Looks like the web platform is missing an mktemp for databases :) > > What it really needs is a makeAllMyTestsPass() :D > > Seriously though, this approach has the benefit that the database name is > deterministic and based on the test case. When debugging, this makes it easy to > find the database for the test in the dev tools / inspector, and look at its > contents. Acknowledged.
	15 indexedDB.deleteDatabase(dbName);

	16 const request = indexedDB.open(dbName, 1);

	17 request.onupgradeneeded = testCase.step_func(event => {

	18 const database = event.target.result;

	19 const transaction = event.target.transaction;

	20 const store = database.createObjectStore('books');

	21 store.name = 'renamed_books';

	22 assert_equals(

	23 store.name, 'books',

	24 'IndexedDB object store renaming should not be web-exposed');

	25 const authorIndex = store.createIndex('by_author', 'author');

	26 authorIndex.name = 'renamed_by_author';

	27 assert_equals(

	28 authorIndex.name, 'by_author',

	29 'IndexedDB object store renaming should not be web-exposed');

	30 });

	31 request.onsuccess = event => {
	foolip 2016/09/09 08:12:17 testCase.step_func, or even step_func_done if you testCase.step_func, or even step_func_done if you like that style. pwnall 2016/09/09 20:50:34 Done. Show quoted text On 2016/09/09 08:12:17, foolip wrote: > testCase.step_func, or even step_func_done if you like that style. Done.
	32 const database = event.target.result;

	33 database.close();

	34 testCase.done();

	35 };

	36 request.onerror = testCase.unreached_func(

	37 'The IndexedDB request should not receive an error event');

	38 }, 'IndexedDB object store and index renaming should not be web-exposed\nThis te st is expected to fail in LayoutTests/webexposed');

	39 </script>

OLD	NEW