Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2276583002: Skip virtual equivalent of async-callstack-async-await*.html layout tests. (Closed)

Created:
4 years, 4 months ago by Łukasz Anforowicz
Modified:
4 years, 4 months ago
Reviewers:
caitp, Dan Ehrenberg
CC:
alexmos, blink-reviews, chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip virtual equivalent of async-callstack-async-await*.html layout tests. Non-virtual async-callstack-async-await*.html tests have been disabled in r409884, but the tests have been flakily running and timing out in the virtual test suites: - Site Isolation Win: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15853 - WebKit Mac10.11 (dbg): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fasyncawait%2Finspector%2Fsources%2Fdebugger-async%2Fasync-await%2Fasync-callstack-async-await2.html Based, on the above, this CL is broadening the test expectations for virtual/asyncawait/.../async-callstack-async-await[23].html so that: - They cover non-Debug builds (since Site Isolation Win tests Release build) - They cover all platforms (since these tests are also flaky on Mac10.11) BUG=636835, 621515 NOTRY=true Committed: https://crrev.com/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339 Cr-Commit-Position: refs/heads/master@{#413786}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
Łukasz Anforowicz
dehrenberg@, could you take a look please? https://codereview.chromium.org/2276583002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2276583002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode595 third_party/WebKit/LayoutTests/TestExpectations:595: crbug.com/636835 virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await3.html ...
4 years, 4 months ago (2016-08-23 17:27:10 UTC) #3
Dan Ehrenberg
lgtm The non-virtual tests are disabled because these tests need a particular feature which requires ...
4 years, 4 months ago (2016-08-23 18:04:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276583002/1
4 years, 4 months ago (2016-08-23 18:07:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 18:12:45 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:15:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339
Cr-Commit-Position: refs/heads/master@{#413786}

Powered by Google App Engine
This is Rietveld 408576698