Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2276573003: Add trace event for FirstMeaningfulPaint candidates (Closed)

Created:
4 years, 4 months ago by Kunihiko Sakamoto
Modified:
4 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trace event for FirstMeaningfulPaint candidates This adds a trace event that is logged every time the provisional FirstMeaningfulPaint timestamp is updated. Trace-based implementations can find FirstMeaningfulPaint for the page load by looking for the last event in the trace. BUG=638124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/1b6b36c1f28b31bdcf35d207d83e2693b75b5408 Cr-Commit-Position: refs/heads/master@{#414296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Kunihiko Sakamoto
4 years, 4 months ago (2016-08-24 05:47:25 UTC) #5
kouhei (in TOK)
The change lg, but I'm not sure if this needs to be landed. Would you ...
4 years, 4 months ago (2016-08-24 10:45:37 UTC) #6
Kunihiko Sakamoto
On 2016/08/24 10:45:37, kouhei wrote: > The change lg, but I'm not sure if this ...
4 years, 3 months ago (2016-08-25 01:28:13 UTC) #7
kouhei (in TOK)
Fair enough. lgtm cq
4 years, 3 months ago (2016-08-25 01:35:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276573003/1
4 years, 3 months ago (2016-08-25 01:36:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 03:44:54 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:48:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b6b36c1f28b31bdcf35d207d83e2693b75b5408
Cr-Commit-Position: refs/heads/master@{#414296}

Powered by Google App Engine
This is Rietveld 408576698