Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2276563006: MIPS: Remove r6 DCHECKs for NEG.fmt instruction (Closed)

Created:
4 years, 3 months ago by miran.karic
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove r6 DCHECKs for NEG.fmt instruction These DCHECKs were causing several test failures or r6. They should not be here because only NEG.PS format was removed in r6, NEG.S and NEG.D instructions remain. BUG= Committed: https://crrev.com/3683344608eb48b45fc7d88a2372d973c509f91f Cr-Commit-Position: refs/heads/master@{#38944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/mips/assembler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
miran.karic
PTAL
4 years, 3 months ago (2016-08-25 12:03:57 UTC) #2
ivica.bogosavljevic
lgtm
4 years, 3 months ago (2016-08-25 14:05:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276563006/1
4 years, 3 months ago (2016-08-25 15:04:42 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-25 15:04:43 UTC) #7
balazs.kilvady
lgtm
4 years, 3 months ago (2016-08-26 11:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276563006/1
4 years, 3 months ago (2016-08-26 12:26:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 12:50:53 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 12:51:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3683344608eb48b45fc7d88a2372d973c509f91f
Cr-Commit-Position: refs/heads/master@{#38944}

Powered by Google App Engine
This is Rietveld 408576698