Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2276563003: Convert editing/execCommand/remove-list-item-1.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/execCommand/remove-list-item-1.html to use w3c test harness This patch converts "editing/execCommand/remove-list-item-1.html" to use w3c test harness to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/e211f36d69738bb1519375a05d716281776655d0 Cr-Commit-Position: refs/heads/master@{#414278}

Patch Set 1 : 2016-08-24T18:19:23 #

Total comments: 2

Patch Set 2 : 2016-08-25T10:29:13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html View 1 1 chunk +25 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-24 09:33:23 UTC) #5
Xiaocheng
lgtm with nit https://codereview.chromium.org/2276563003/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html File third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html (right): https://codereview.chromium.org/2276563003/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html#newcode21 third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html:21: // TODO(yosin): We should study why ...
4 years, 3 months ago (2016-08-25 01:11:49 UTC) #8
yosin_UTC9
Thanks for reviewing! Committing... https://codereview.chromium.org/2276563003/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html File third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html (right): https://codereview.chromium.org/2276563003/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html#newcode21 third_party/WebKit/LayoutTests/editing/execCommand/remove-list-1.html:21: // TODO(yosin): We should study ...
4 years, 3 months ago (2016-08-25 01:30:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276563003/20001
4 years, 3 months ago (2016-08-25 01:31:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 02:56:15 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:58:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e211f36d69738bb1519375a05d716281776655d0
Cr-Commit-Position: refs/heads/master@{#414278}

Powered by Google App Engine
This is Rietveld 408576698