ui/app_list/views/app_list_main_view.h - Issue 2276553002: arc: Open launcher after installing app from Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_main_view.h

Issue 2276553002: arc: Open launcher after installing app from Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/arc/arc_app_list_prefs.h ('K') | « chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc ('k') | ui/app_list/views/app_list_main_view.cc » ('j') | ui/app_list/views/app_list_main_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/app_list/views/app_list_main_view.h

diff --git a/ui/app_list/views/app_list_main_view.h b/ui/app_list/views/app_list_main_view.h

index 740ff3e46b24340d0f960a19c84a2aabf1aedc15..29b41d179ecef75aa09f7eb9839a67e2f1d02ab4 100644

--- a/ui/app_list/views/app_list_main_view.h

+++ b/ui/app_list/views/app_list_main_view.h

@@ -95,8 +95,8 @@ class APP_LIST_EXPORT AppListMainView : public views::View,

// Invoked when |icon_loading_wait_timer_| fires.

void OnIconLoadingWaitTimer();

- // Invoked from an IconLoader when icon loading is finished.

- void OnItemIconLoaded(IconLoader* loader);

+ // Invoked from an IconLoader when icon loading is finished or item is closed.

+ void OnItemClosedOrIconLoaded(IconLoader* loader);

xiyuan 2016/08/23 17:54:17 nit: OnItemClosedOrIconLoaded -> OnIconLoaderFinis

khmel 2016/08/23 18:03:12 Much nicer :)

// Overridden from AppsGridViewDelegate:

void ActivateApp(AppListItem* item, int event_flags) override;