arc: Open launcher after installing app from Android

arc: Open launcher after installing app from Android

This Implements showing app list when user installs new package.
App list is not shown for app from system packages, or auxulary
packages. App list is shown on the page that contains newly
installed app.

BUG=b/30953079
BUG=640226
TEST=unit_tests extended browser_tests
TEST=manually on device

Committed: https://crrev.com/29f5caf832d9e2e14c1ad5de1ab6c94cc5c41e33
Cr-Commit-Position: refs/heads/master@{#414100}

[khmel, 2016-08-23 16:26:26]

khmel@chromium.org changed reviewers:
+ lgcheng@google.com, xiyuan@chromium.org

[khmel, 2016-08-23 16:26:27]

PTAL

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_main_view.cc (right):

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_main_view.cc:76:
owner_->OnItemClosedOrIconLoaded(this);
This fix crash reason in my new test and I see this may be real crash condition
(rare?) in production. It is not guaranty that item is not destroyed prior to
icon update.

[xiyuan, 2016-08-23 17:54:17]

lgtm

https://codereview.chromium.org/2276553002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.h (right):

https://codereview.chromium.org/2276553002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.h:305: void
MayShowPackageInAppLauncher(
nit: MayShowPackageInAppLauncher -> May*be*ShowPackageInAppLauncher to be
consistent with other code, e.g. [1]

[1]
https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_window.h?rcl=0...

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_main_view.h (right):

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_main_view.h:99: void
OnItemClosedOrIconLoaded(IconLoader* loader);
nit: OnItemClosedOrIconLoaded -> OnIconLoaderFinished ?

[khmel, 2016-08-23 18:03:11]

khmel@chromium.org changed reviewers:
+ skuhne@chromium.org

[khmel, 2016-08-23 18:03:12]

Thanks Xiyuan for quick review!

Adding Stefan:(c/b/ui/ash/launcher/arc_app_launcher_browsertest.cc)

PTAL

https://codereview.chromium.org/2276553002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.h (right):

https://codereview.chromium.org/2276553002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.h:305: void
MayShowPackageInAppLauncher(
On 2016/08/23 17:54:17, xiyuan wrote:
> nit: MayShowPackageInAppLauncher -> May*be*ShowPackageInAppLauncher to be
> consistent with other code, e.g. [1]
> 
> [1]
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_window.h?rcl=0...

Done.

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_main_view.h (right):

https://codereview.chromium.org/2276553002/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_main_view.h:99: void
OnItemClosedOrIconLoaded(IconLoader* loader);
On 2016/08/23 17:54:17, xiyuan wrote:
> nit: OnItemClosedOrIconLoaded -> OnIconLoaderFinished ?

Much nicer :)

[Mr4D (OOO till 08-26), 2016-08-23 18:37:12]

lgtm

[khmel, 2016-08-24 14:59:16]

Thanks for review!

[khmel, 2016-08-24 14:59:21]

Thanks for review!

[khmel, 2016-08-24 14:59:22]

Thanks for review!

[khmel, 2016-08-24 14:59:27]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-24 14:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2276553002/#ps60001
(title: "use existing pointer")

[commit-bot: I haz the power, 2016-08-24 14:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2016-08-24 16:27:12]

The CQ bit was unchecked by khmel@chromium.org

[khmel, 2016-08-24 17:03:06]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-24 17:03:07]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2276553002/#ps80001
(title: "fix browser_tests")

[commit-bot: I haz the power, 2016-08-24 17:03:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:55:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-24 17:56:39]

Description was changed from

==========
arc: Open launcher after installing app from Android

This Implements showing app list when user installs new package.
App list is not shown for app from system packages, or auxulary
packages. App list is shown on the page that contains newly
installed app.

BUG=b/30953079
BUG=640226
TEST=unit_tests extended browser_tests
TEST=manually on device
==========

to

==========
arc: Open launcher after installing app from Android

This Implements showing app list when user installs new package.
App list is not shown for app from system packages, or auxulary
packages. App list is shown on the page that contains newly
installed app.

BUG=b/30953079
BUG=640226
TEST=unit_tests extended browser_tests
TEST=manually on device

Committed: https://crrev.com/29f5caf832d9e2e14c1ad5de1ab6c94cc5c41e33
Cr-Commit-Position: refs/heads/master@{#414100}
==========

[commit-bot: I haz the power, 2016-08-24 17:56:40]

Patchset 5 (id:??) landed as
https://crrev.com/29f5caf832d9e2e14c1ad5de1ab6c94cc5c41e33
Cr-Commit-Position: refs/heads/master@{#414100}