Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2276533002: f16<->f32 ftz is an optional thing for speed. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

f16<->f32 ftz is an optional thing for speed. The ARMv8 asm path actually does it right... that should be okay. My Nexus 5x fails `dm -m _finite_ftz` before this and passes after it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276533002 TBR=msarett@google.com Committed: https://skia.googlesource.com/skia/+/a2d2f386000acdc0e10bd38757ece8d6ab78bc25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/core/SkHalf.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/Float16Test.cpp View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
4 years, 4 months ago (2016-08-23 15:34:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276533002/1
4 years, 4 months ago (2016-08-23 15:34:38 UTC) #9
msarett
lgtm
4 years, 4 months ago (2016-08-23 15:50:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 15:58:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a2d2f386000acdc0e10bd38757ece8d6ab78bc25

Powered by Google App Engine
This is Rietveld 408576698