Issue 227653006: ContentView->ContentViewCore in Shell/ShellManager.

Issue 227653006: ContentView->ContentViewCore in Shell/ShellManager. (Closed)

Created:
6 years, 8 months ago by Yaron

Modified:
6 years, 8 months ago

Reviewers:
Ted C

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ContentView->ContentViewCore in Shell/ShellManager. Basically just ensures you can always directly get a ContentViewCore in ContentShell code. There's too many callers for one CL to switch everyone over to that. More clean-up is needed but it seems like the next strings I pull result in a fair bit of diff. Seems like a small enough chunk that is a logical change. BUG=360664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263066

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -43 lines)			Patch
M	chrome/test/android/javatests/src/org/chromium/chrome/test/util/TabUtils.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentView.java	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/android/java/src/org/chromium/content_shell/Shell.java	View		7 chunks	+20 lines, -11 lines	0 comments	Download
M	content/shell/android/java/src/org/chromium/content_shell/ShellManager.java	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java	View		5 chunks	+10 lines, -10 lines	0 comments	Download
M	content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java	View	1 2	5 chunks	+20 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/227653006/40001

6 years, 8 months ago (2014-04-10 17:26:23 UTC) #5

Message was sent while issue was closed.

Change committed as 263066

Expand Messages | Collapse Messages