Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 227653002: Hook up gin platform to blink, and explicitly manage the main thread isolate (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
haraken, dcarney
CC:
blink-reviews
Visibility:
Public.

Description

Hook up gin platform to blink, and explicitly manage the main thread isolate We'll soon get rid of the v8 default isolate, so we'll need to manage our own. To test the platform implementation, run with --js-flags="--noparallel_sweeping --concurrent-sweeping --job-based-sweeping" BUG=359977 R=dcarney@chromium.org,haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebKit.cpp View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-07 12:13:45 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-07 12:22:43 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-07 17:53:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/227653002/1
6 years, 8 months ago (2014-04-07 17:53:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 18:11:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-07 18:11:08 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-08 07:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/227653002/1
6 years, 8 months ago (2014-04-08 07:27:49 UTC) #8
commit-bot: I haz the power
Change committed as 171036
6 years, 8 months ago (2014-04-08 07:56:24 UTC) #9
yurys
6 years, 8 months ago (2014-04-08 12:36:08 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/225023038/ by yurys@chromium.org.

The reason for reverting is: Broke browser_tests on Linux:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35802
.

Powered by Google App Engine
This is Rietveld 408576698